From 2215aced19cc7103f7eae4241770470ed8ec2455 Mon Sep 17 00:00:00 2001 From: nesquena-hermes Date: Fri, 10 Apr 2026 10:10:28 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20unskip=2016=20approval=20tests=20?= =?UTF-8?q?=E2=80=94=20remove=20stale=20has=5Fpending/pop=5Fpending=20impo?= =?UTF-8?q?rts?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These two symbols were removed from tools.approval when the agent renamed has_pending -> has_blocking_approval (checks gateway queue, not _pending dict) and dropped pop_pending. They were only in the import block — never used in any test body — but their absence caused the entire file to skip via the APPROVAL_AVAILABLE guard. Before: 595 collected, 579 passed, 16 skipped After: 595 collected, 595 passed, 0 skipped Co-authored-by: Nathan Esquenazi --- tests/test_approval_unblock.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_approval_unblock.py b/tests/test_approval_unblock.py index 975ab15..9fa10e9 100644 --- a/tests/test_approval_unblock.py +++ b/tests/test_approval_unblock.py @@ -27,9 +27,11 @@ try: _lock, _ApprovalEntry, submit_pending, - has_pending, - pop_pending, ) + # has_pending and pop_pending were removed from tools.approval when the + # agent renamed has_pending -> has_blocking_approval (gateway queue check) + # and removed the polling-mode pop_pending. Routes now check _pending + # directly. These symbols are no longer part of the public API. APPROVAL_AVAILABLE = True except ImportError: APPROVAL_AVAILABLE = False