Sabo/webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove unused ordered variable, add hoisting note

Browse Source 
Agent review feedback: ordered array was constructed but never iterated
(the new code uses groups[] instead). Removed the dead variable.
Added comment noting function hoisting for _renderOneSession.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Nathan Esquenazi
2026-04-04 14:24:04 -07:00
parent 42590fceb3
commit a2243f4c4f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/sessions.js
View File

@@ -198,7 +198,6 @@ function renderSessionListFromCache(){
// Date grouping: Pinned / Today / Yesterday / Earlier // Date grouping: Pinned / Today / Yesterday / Earlier
const now=Date.now(); const now=Date.now();
const ONE_DAY=86400000; const ONE_DAY=86400000;
const ordered=[...pinned,...unpinned].slice(0,50);
// Collapse state persisted in localStorage // Collapse state persisted in localStorage
let _groupCollapsed={}; let _groupCollapsed={};
try{_groupCollapsed=JSON.parse(localStorage.getItem('hermes-date-groups-collapsed')||'{}');}catch(e){} try{_groupCollapsed=JSON.parse(localStorage.getItem('hermes-date-groups-collapsed')||'{}');}catch(e){}
@@ -244,6 +243,7 @@ function renderSessionListFromCache(){
list.appendChild(wrapper); list.appendChild(wrapper);
} }
// ── Render session items (extracted for group body use) ── // ── Render session items (extracted for group body use) ──
// Note: declared after the groups loop but available via function hoisting.
function _renderOneSession(s){ function _renderOneSession(s){
const el=document.createElement('div'); const el=document.createElement('div');
const isActive=S.session&&s.session_id===S.session.session_id; const isActive=S.session&&s.session_id===S.session.session_id;