feat(i18n): complete zh-CN hardening and locale consistency

tests/test_chinese_locale.py

@@ -0,0 +1,65 @@
+from collections import Counter
+from pathlib import Path
+import re
+
+
+REPO = Path(__file__).resolve().parent.parent
+
+
+def read(path: Path) -> str:
+    return path.read_text(encoding="utf-8")
+
+
+def test_chinese_locale_block_exists():
+    src = read(REPO / "static" / "i18n.js")
+    assert "\n  zh: {" in src
+    assert "_lang: 'zh'" in src
+    assert "_speech: 'zh-CN'" in src
+
+
+def test_chinese_locale_includes_representative_translations():
+    src = read(REPO / "static" / "i18n.js")
+    expected = [
+        "settings_title: '\\u8bbe\\u7f6e'",
+        "login_title: '\\u767b\\u5f55'",
+        "approval_heading: '需要审批'",
+        "tab_tasks: '任务'",
+        "tab_profiles: '配置'",
+        "session_time_just_now: '刚刚'",
+        "onboarding_title: '欢迎使用 Hermes Web UI'",
+        "onboarding_complete: '引导完成'",
+    ]
+    for entry in expected:
+        assert entry in src
+
+
+def test_chinese_locale_covers_english_keys():
+    src = read(REPO / "static" / "i18n.js")
+    en_match = re.search(r"\n  en: \{([\s\S]*?)\n  \},\n\n  es: \{", src)
+    zh_match = re.search(
+        r"\n  zh: \{([\s\S]*?)\n  \},\n\n  // Traditional Chinese \(zh-Hant\)",
+        src,
+    )
+    assert en_match, "English locale block not found"
+    assert zh_match, "Chinese locale block not found"
+
+    key_pattern = re.compile(r"^\s{4}([a-zA-Z0-9_]+):", re.MULTILINE)
+    en_keys = set(key_pattern.findall(en_match.group(1)))
+    zh_keys = set(key_pattern.findall(zh_match.group(1)))
+
+    missing = sorted(en_keys - zh_keys)
+    assert not missing, f"Chinese locale missing keys: {missing}"
+
+
+def test_chinese_locale_has_no_duplicate_keys():
+    src = read(REPO / "static" / "i18n.js")
+    zh_match = re.search(
+        r"\n  zh: \{([\s\S]*?)\n  \},\n\n  // Traditional Chinese \(zh-Hant\)",
+        src,
+    )
+    assert zh_match, "Chinese locale block not found"
+
+    key_pattern = re.compile(r"^\s{4}([a-zA-Z0-9_]+):", re.MULTILINE)
+    keys = key_pattern.findall(zh_match.group(1))
+    duplicates = sorted(k for k, count in Counter(keys).items() if count > 1)
+    assert not duplicates, f"Chinese locale has duplicate keys: {duplicates}"

tests/test_language_precedence.py

@@ -0,0 +1,88 @@
+import json
+import pathlib
+import re
+import subprocess
+import textwrap
+
+
+REPO_ROOT = pathlib.Path(__file__).parent.parent.resolve()
+I18N_JS = (REPO_ROOT / "static" / "i18n.js").read_text(encoding="utf-8")
+BOOT_JS = (REPO_ROOT / "static" / "boot.js").read_text(encoding="utf-8")
+PANELS_JS = (REPO_ROOT / "static" / "panels.js").read_text(encoding="utf-8")
+
+
+def _run_i18n_case(script_expr: str) -> dict:
+    wrapped_expr = f"(() => ({script_expr}))()"
+    script = textwrap.dedent(
+        f"""
+        const fs = require('fs');
+        const vm = require('vm');
+        const src = fs.readFileSync({json.dumps(str(REPO_ROOT / "static" / "i18n.js"))}, 'utf8');
+        const storage = {{}};
+        const ctx = {{
+          localStorage: {{
+            getItem: (k) => Object.prototype.hasOwnProperty.call(storage, k) ? storage[k] : null,
+            setItem: (k, v) => {{ storage[k] = String(v); }},
+          }},
+          document: {{
+            documentElement: {{ lang: '' }},
+            querySelectorAll: () => [],
+          }},
+        }};
+        vm.createContext(ctx);
+        vm.runInContext(src, ctx);
+        const out = vm.runInContext({json.dumps(wrapped_expr)}, ctx);
+        process.stdout.write(JSON.stringify(out));
+        """
+    )
+    proc = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+    return json.loads(proc.stdout)
+
+
+def test_i18n_exposes_locale_resolvers():
+    assert "function resolveLocale(" in I18N_JS
+    assert "function resolvePreferredLocale(" in I18N_JS
+
+
+def test_locale_alias_resolution_and_precedence_logic():
+    result = _run_i18n_case(
+        """
+{
+  zhCn: resolveLocale('zh-CN'),
+  zhTw: resolveLocale('zh_TW'),
+  enUs: resolveLocale('EN-us'),
+  esMx: resolveLocale('es-MX'),
+  bad: resolveLocale('xx-YY'),
+  preferred1: resolvePreferredLocale('zh-CN', 'en'),
+  preferred2: resolvePreferredLocale('xx-YY', 'zh-Hant'),
+  preferred3: resolvePreferredLocale('', 'xx-YY'),
+}
+        """
+    )
+    assert result["zhCn"] == "zh"
+    assert result["zhTw"] == "zh-Hant"
+    assert result["enUs"] == "en"
+    assert result["esMx"] == "es"
+    assert result["bad"] is None
+    assert result["preferred1"] == "zh"
+    assert result["preferred2"] == "zh-Hant"
+    assert result["preferred3"] == "en"
+
+
+def test_set_locale_normalizes_alias_and_persists_canonical_key():
+    result = _run_i18n_case(
+        """
+{
+  ...(setLocale('zh-CN'), {}),
+  saved: localStorage.getItem('hermes-lang'),
+  htmlLang: document.documentElement.lang,
+}
+        """
+    )
+    assert result["saved"] == "zh"
+    assert result["htmlLang"] == "zh-CN"
+
+
+def test_boot_and_settings_panel_use_shared_locale_precedence():
+    assert re.search(r"resolvePreferredLocale\(s\.language\s*,\s*localStorage\.getItem\('hermes-lang'\)\)", BOOT_JS)
+    assert re.search(r"resolvePreferredLocale\(settings\.language\s*,\s*localStorage\.getItem\('hermes-lang'\)\)", PANELS_JS)

tests/test_login_locale.py

@@ -0,0 +1,64 @@
+import json
+import urllib.error
+import urllib.request
+
+
+BASE = "http://127.0.0.1:8788"
+
+
+def get(path):
+    with urllib.request.urlopen(BASE + path, timeout=10) as r:
+        return json.loads(r.read()), r.status
+
+
+def get_raw(path):
+    with urllib.request.urlopen(BASE + path, timeout=10) as r:
+        return r.read().decode(), r.status
+
+
+def post(path, body=None):
+    data = json.dumps(body or {}).encode()
+    req = urllib.request.Request(
+        BASE + path, data=data, headers={"Content-Type": "application/json"}
+    )
+    try:
+        with urllib.request.urlopen(req, timeout=10) as r:
+            return json.loads(r.read()), r.status
+    except urllib.error.HTTPError as e:
+        return json.loads(e.read()), e.code
+
+
+def _current_language():
+    settings, status = get("/api/settings")
+    assert status == 200
+    return settings.get("language") or "en"
+
+
+def test_login_page_uses_simplified_chinese_for_zh_cn_alias():
+    prev_lang = _current_language()
+    try:
+        saved, status = post("/api/settings", {"language": "zh-CN"})
+        assert status == 200
+        assert saved.get("language") == "zh-CN"
+        html, status2 = get_raw("/login")
+        assert status2 == 200
+        assert 'lang="zh-CN"' in html
+        assert "\u767b\u5f55" in html
+        assert "\u8f93\u5165\u5bc6\u7801\u7ee7\u7eed\u4f7f\u7528" in html
+    finally:
+        post("/api/settings", {"language": prev_lang})
+
+
+def test_login_page_uses_traditional_chinese_for_zh_hant():
+    prev_lang = _current_language()
+    try:
+        saved, status = post("/api/settings", {"language": "zh-Hant"})
+        assert status == 200
+        assert saved.get("language") == "zh-Hant"
+        html, status2 = get_raw("/login")
+        assert status2 == 200
+        assert 'lang="zh-TW"' in html
+        assert "\u8f38\u5165\u5bc6\u78bc\u7e7c\u7e8c\u4f7f\u7528" in html
+        assert "\u5bc6\u78bc\u932f\u8aa4" in html
+    finally:
+        post("/api/settings", {"language": prev_lang})