b86ace6ce3
* fix: custom provider with slash model name no longer rerouted to OpenRouter (#255) When base_url is configured in config.yaml, resolve_model_provider() now trusts the configured provider/base_url entirely and skips the slash-based OpenRouter heuristic. Fixes google/gemma-4-26b-a4b with provider:custom being silently routed to OpenRouter, resulting in 401 errors. Fixes #230 * test: mobile layout regression suite — 14 tests for every QA run (#254) Adds tests/test_mobile_layout.py with 14 static regression tests that run on every QA pass to catch mobile layout breakage before it reaches prod. Covers: breakpoints at 900px/640px, right panel slide-over CSS, mobile overlay, bottom nav, files button, profile dropdown z-index, chip overflow, workspace close, 100dvh, 44px touch targets, 16px font-size on textarea. * feat: /skills slash command lists and filters available Hermes skills (#257) Adds /skills [query] command to commands.js. Fetches from /api/skills, groups by category (alphabetically sorted), displays as a formatted assistant message. Optional query filters by name, description, or category. i18n keys added for en, de, zh, zh-Hant. 1 regression test added. Fixes #248 * feat: shared app dialogs replace native confirm()/prompt() calls (#251) Adds showConfirmDialog() and showPromptDialog() helpers to ui.js, backed by a themed #appDialogOverlay. Replaces all 11 native browser confirm/prompt call sites across panels.js, sessions.js, ui.js, workspace.js. Supports: danger mode, keyboard focus trap (Tab/Escape/Enter), focus restore, ARIA roles, mobile-responsive stacked buttons at 640px. i18n for en/de/zh/zh-Hant. 5 new tests in test_sprint33.py verify markup, CSS, helpers, and absence of native dialog calls. Extracted from PR #242. * fix: Android Chrome mobile — workspace panel close + profile dropdown (#256) Fix #247: toggleMobileFiles() now shows/hides the mobile overlay when toggling the right workspace panel. New closeMobileFiles() helper closes the panel with correct overlay state tracking. Overlay onclick calls both closeMobileSidebar() and closeMobileFiles(). Mobile-only close button (x) added to workspace panel header. Fix #246: profile dropdown uses position:fixed;top:56px;right:8px at max-width:900px, escaping the overflow-x:auto stacking context that was clipping it on Android Chrome. Fix applied during review: closeMobileSidebar() now checks if the right panel is still open before hiding the overlay, preventing the overlay from disappearing when only the sidebar is closed. Fixes #247 Fixes #246 * feat: session ⋯ action dropdown replaces per-row buttons (#252) Replaces the 5 per-row hover action buttons (pin/move/archive/duplicate/trash) with a single ⋯ trigger that opens a positioned dropdown menu. Menu has full keyboard (Escape), click-outside, scroll, and resize-reposition handling. Position:fixed prevents sidebar clipping. 5 actions: Pin/Unpin, Move to project, Archive/Unarchive, Duplicate, Delete (danger style). Each with icon and descriptive subtitle. Updated test_sprint16.py: test_sessions_js_uses_action_menu_not_per_row_buttons asserts the new trigger and menu functions exist, old per-row classes are gone. Extracted from PR #242. * docs: v0.47.0 release notes, bump version, update test counts (645) --------- Co-authored-by: Nathan Esquenazi <nesquena@gmail.com>
60 lines
1.8 KiB
Python
60 lines
1.8 KiB
Python
"""
|
|
Sprint 33 Tests: Shared app dialogs replace native confirm/prompt usage.
|
|
|
|
These tests verify the static assets expose the reusable confirm/input modal
|
|
and that browser-native confirm/prompt calls are no longer used in the Web UI.
|
|
"""
|
|
|
|
import pathlib
|
|
import re
|
|
|
|
|
|
REPO = pathlib.Path(__file__).parent.parent
|
|
|
|
|
|
def read(path):
|
|
return (REPO / path).read_text(encoding="utf-8")
|
|
|
|
|
|
def test_index_has_shared_app_dialog_markup():
|
|
html = read("static/index.html")
|
|
assert 'id="appDialogOverlay"' in html
|
|
assert 'id="appDialog"' in html
|
|
assert 'id="appDialogTitle"' in html
|
|
assert 'id="appDialogDesc"' in html
|
|
assert 'id="appDialogInput"' in html
|
|
assert 'id="appDialogCancel"' in html
|
|
assert 'id="appDialogConfirm"' in html
|
|
|
|
|
|
def test_app_dialog_css_rules_exist():
|
|
css = read("static/style.css")
|
|
for selector in (
|
|
".app-dialog-overlay",
|
|
".app-dialog",
|
|
".app-dialog-input",
|
|
".app-dialog-actions",
|
|
".app-dialog-btn.confirm",
|
|
".app-dialog-btn.confirm.danger",
|
|
):
|
|
assert selector in css, f"missing CSS selector: {selector}"
|
|
|
|
|
|
def test_ui_js_exposes_shared_dialog_helpers():
|
|
src = read("static/ui.js")
|
|
assert "function showConfirmDialog(opts={})" in src
|
|
assert "function showPromptDialog(opts={})" in src
|
|
assert "document.addEventListener('keydown'" in src
|
|
|
|
|
|
def test_no_native_confirm_calls_remain_in_static_js():
|
|
for path in (REPO / "static").glob("*.js"):
|
|
src = path.read_text(encoding="utf-8")
|
|
assert not re.search(r"\bconfirm\s*\(", src), f"native confirm() remains in {path.name}"
|
|
|
|
|
|
def test_no_native_prompt_calls_remain_in_static_js():
|
|
for path in (REPO / "static").glob("*.js"):
|
|
src = path.read_text(encoding="utf-8")
|
|
assert not re.search(r"\bprompt\s*\(", src), f"native prompt() remains in {path.name}"
|