Sabo/webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: unskip 16 approval tests — remove stale has_pending/pop_pending imports

Browse Source 
These two symbols were removed from tools.approval when the agent renamed
has_pending -> has_blocking_approval (checks gateway queue, not _pending dict)
and dropped pop_pending. They were only in the import block — never used in
any test body — but their absence caused the entire file to skip via the
APPROVAL_AVAILABLE guard.

Before: 595 collected, 579 passed, 16 skipped
After:  595 collected, 595 passed, 0 skipped

Co-authored-by: Nathan Esquenazi <nesquena@gmail.com>
This commit is contained in:
nesquena-hermes
2026-04-10 10:10:28 -07:00
committed by GitHub
parent 4947a6b0c3
commit 2215aced19
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_approval_unblock.py
View File

@@ -27,9 +27,11 @@ try:
_lock, _lock,
_ApprovalEntry, _ApprovalEntry,
submit_pending, submit_pending,
has_pending,
pop_pending,
) )
# has_pending and pop_pending were removed from tools.approval when the
# agent renamed has_pending -> has_blocking_approval (gateway queue check)
# and removed the polling-mode pop_pending. Routes now check _pending
# directly. These symbols are no longer part of the public API.
APPROVAL_AVAILABLE = True APPROVAL_AVAILABLE = True
except ImportError: except ImportError:
APPROVAL_AVAILABLE = False APPROVAL_AVAILABLE = False