feat: add MiniMax M2.7 to fallback model list and fix env var detection — PR #650 by @octo-patch

MiniMax M2.7/highspeed added to _FALLBACK_MODELS. MINIMAX_API_KEY and MINIMAX_CN_API_KEY added to env scan tuple so os.environ is checked. 11 tests. Independent review by @nesquena confirmed correct, needed rebase only.
This commit is contained in:
nesquena-hermes
2026-04-18 00:18:20 -07:00
committed by GitHub
parent 20a5f48a1f
commit 75e6595e06
4 changed files with 160 additions and 1 deletions

View File

@@ -1,5 +1,11 @@
# Hermes Web UI -- Changelog
## [v0.50.84] — 2026-04-18
### Fixed
- **MiniMax M2.7 now appears in the model dropdown for OpenRouter users** — `MiniMax-M2.7` and `MiniMax-M2.7-highspeed` were present in `_PROVIDER_MODELS['minimax']` but absent from `_FALLBACK_MODELS`, so OpenRouter users (who see the fallback list) never saw them. Both models added to the fallback list under the `MiniMax` provider label.
- **`MINIMAX_API_KEY` env var now triggers MiniMax detection** — the env scan tuple in `get_available_models()` was missing `MINIMAX_API_KEY` and `MINIMAX_CN_API_KEY`, so users who set those vars directly in `os.environ` (rather than in `~/.hermes/.env`) did not see the MiniMax provider in the dropdown. Both keys now scanned. (PR #650 by @octo-patch)
## [v0.50.83] — 2026-04-18
### Fixed

View File

@@ -449,6 +449,9 @@ _FALLBACK_MODELS = [
{"provider": "xAI", "id": "x-ai/grok-4.20", "label": "Grok 4.20"},
# Mistral
{"provider": "Mistral", "id": "mistralai/mistral-large-latest", "label": "Mistral Large"},
# MiniMax
{"provider": "MiniMax", "id": "minimax/MiniMax-M2.7", "label": "MiniMax M2.7"},
{"provider": "MiniMax", "id": "minimax/MiniMax-M2.7-highspeed", "label": "MiniMax M2.7 Highspeed"},
]
# Provider display names for known Hermes provider IDs
@@ -819,6 +822,8 @@ def get_available_models() -> dict:
"DEEPSEEK_API_KEY",
"OPENCODE_ZEN_API_KEY",
"OPENCODE_GO_API_KEY",
"MINIMAX_API_KEY",
"MINIMAX_CN_API_KEY",
):
val = os.getenv(k)
if val:

View File

@@ -592,7 +592,7 @@
<div class="settings-section-title">System</div>
<div class="settings-section-meta">Instance version and access controls.</div>
</div>
<span class="settings-version-badge">v0.50.83</span>
<span class="settings-version-badge">v0.50.84</span>
</div>
<div class="settings-field" style="border-top:1px solid var(--border);padding-top:12px;margin-top:8px">
<label for="settingsPassword" data-i18n="settings_label_password">Access Password</label>

View File

@@ -0,0 +1,148 @@
"""
Tests for MiniMax provider support in the model/provider discovery layer.
Covers:
- MiniMax models appear in the fallback model list
- MINIMAX_API_KEY env var is scanned and detected from os.environ
- @minimax: provider hint routing works correctly
- minimax/MiniMax-M2.7 (slash format) is routed via openrouter when active provider differs
"""
import os
import api.config as config
# ── Helper ────────────────────────────────────────────────────────────────────
def _resolve_with_config(model_id, provider=None, base_url=None):
old_cfg = dict(config.cfg)
model_cfg = {}
if provider:
model_cfg['provider'] = provider
if base_url:
model_cfg['base_url'] = base_url
config.cfg['model'] = model_cfg if model_cfg else {}
try:
return config.resolve_model_provider(model_id)
finally:
config.cfg.clear()
config.cfg.update(old_cfg)
# ── Fallback model list ───────────────────────────────────────────────────────
def test_minimax_m2_7_in_fallback_models():
"""MiniMax-M2.7 must appear in the hardcoded fallback model list."""
ids = [m['id'] for m in config._FALLBACK_MODELS]
assert 'minimax/MiniMax-M2.7' in ids, (
f"minimax/MiniMax-M2.7 missing from _FALLBACK_MODELS. Found: {ids}"
)
def test_minimax_m2_7_highspeed_in_fallback_models():
"""MiniMax-M2.7-highspeed must appear in the hardcoded fallback model list."""
ids = [m['id'] for m in config._FALLBACK_MODELS]
assert 'minimax/MiniMax-M2.7-highspeed' in ids, (
f"minimax/MiniMax-M2.7-highspeed missing from _FALLBACK_MODELS. Found: {ids}"
)
def test_minimax_fallback_provider_label():
"""MiniMax fallback entries must use 'MiniMax' as the provider label."""
minimax_entries = [m for m in config._FALLBACK_MODELS if 'minimax' in m['id'].lower()]
assert minimax_entries, "No MiniMax entries found in _FALLBACK_MODELS"
for entry in minimax_entries:
assert entry['provider'] == 'MiniMax', (
f"Expected provider='MiniMax', got '{entry['provider']}' for {entry['id']}"
)
# ── _PROVIDER_MODELS ──────────────────────────────────────────────────────────
def test_minimax_provider_models_has_m2_7():
"""_PROVIDER_MODELS['minimax'] must include MiniMax-M2.7."""
models = config._PROVIDER_MODELS.get('minimax', [])
ids = [m['id'] for m in models]
assert 'MiniMax-M2.7' in ids, (
f"MiniMax-M2.7 missing from _PROVIDER_MODELS['minimax']. Found: {ids}"
)
def test_minimax_provider_models_has_highspeed():
"""_PROVIDER_MODELS['minimax'] must include MiniMax-M2.7-highspeed."""
models = config._PROVIDER_MODELS.get('minimax', [])
ids = [m['id'] for m in models]
assert 'MiniMax-M2.7-highspeed' in ids, (
f"MiniMax-M2.7-highspeed missing from _PROVIDER_MODELS['minimax']. Found: {ids}"
)
# ── MINIMAX_API_KEY env var detection ─────────────────────────────────────────
def test_minimax_api_key_in_env_scan_tuple():
"""MINIMAX_API_KEY must be included in the env var scan performed by
get_available_models(), so users who export MINIMAX_API_KEY see the
MiniMax provider in the dropdown without editing ~/.hermes/.env."""
import inspect, ast, textwrap
src = inspect.getsource(config.get_available_models)
assert 'MINIMAX_API_KEY' in src, (
"MINIMAX_API_KEY not found in get_available_models() source — "
"it must be added to the env var scan tuple so os.environ is checked."
)
def test_minimax_cn_api_key_in_env_scan_tuple():
"""MINIMAX_CN_API_KEY must also be scanned (mainland China API key variant)."""
import inspect
src = inspect.getsource(config.get_available_models)
assert 'MINIMAX_CN_API_KEY' in src, (
"MINIMAX_CN_API_KEY not found in get_available_models() source."
)
def test_minimax_detected_from_os_environ(monkeypatch):
"""Setting MINIMAX_API_KEY in os.environ triggers minimax provider detection."""
monkeypatch.setenv('MINIMAX_API_KEY', 'test-key-from-env')
old_cfg = dict(config.cfg)
# Clear model config so the env-var fallback path is exercised
config.cfg['model'] = {}
try:
result = config.get_available_models()
provider_names = [g['provider'] for g in result['groups']]
assert 'MiniMax' in provider_names, (
f"MiniMax not detected when MINIMAX_API_KEY is set in os.environ. "
f"Active provider groups: {provider_names}"
)
finally:
config.cfg.clear()
config.cfg.update(old_cfg)
# ── Model routing ─────────────────────────────────────────────────────────────
def test_provider_hint_minimax_m2_7():
"""@minimax:MiniMax-M2.7 routes to minimax provider with bare model name."""
model, provider, base_url = _resolve_with_config(
'@minimax:MiniMax-M2.7', provider='anthropic',
)
assert model == 'MiniMax-M2.7'
assert provider == 'minimax'
assert base_url is None
def test_provider_hint_minimax_highspeed():
"""@minimax:MiniMax-M2.7-highspeed routes to minimax provider."""
model, provider, base_url = _resolve_with_config(
'@minimax:MiniMax-M2.7-highspeed', provider='openai',
)
assert model == 'MiniMax-M2.7-highspeed'
assert provider == 'minimax'
def test_minimax_slash_format_routes_openrouter_when_not_active():
"""minimax/MiniMax-M2.7 (slash format) routes via openrouter when active
provider is anthropic (cross-provider routing)."""
model, provider, base_url = _resolve_with_config(
'minimax/MiniMax-M2.7', provider='anthropic',
)
assert model == 'minimax/MiniMax-M2.7'
assert provider == 'openrouter'